100 Star 443 Fork 295

OpenHarmony / kernel_liteos_m

 / 详情

Inter repository path include dependency

Fixing
Bug
Opened this issue  
2021-09-09 22:46

【模块名_概率】简要描述: when including header files, if the dependent header file is across different repository, then relative path shouldn't be used. Need to include that path in build files.

example:

diff --git a/kal/cmsis/cmsis_os2.h b/kal/cmsis/cmsis_os2.h
index b149eba..8810167 100644
--- a/kal/cmsis/cmsis_os2.h
+++ b/kal/cmsis/cmsis_os2.h
@@ -29,4 +29,4 @@
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#include "../../../../third_party/cmsis/CMSIS/RTOS2/Include/cmsis_os2.h"
+#include "CMSIS/RTOS2/Include/cmsis_os2.h"

【环境信息】:

  • 网络环境
  • 硬件开发板型号
  • 软件版本信息或tag节点
  • 测试环境
  • 其他

【预置条件】:

【测试步骤】:

【预期结果】:

【实际结果】:

【恢复手段】:

【出现概率】:问题出现次数/实际测试次数

【定位信息】:

    1. Log、截图、多媒体文件等,所有和问题有关的信息:

Comments (2)

Nagesh created缺陷
Nagesh set related repository to OpenHarmony/kernel_liteos_m
Denny set assignee to Caoruihong
Expand operation logs

this is not a technical issue but a historical issue, the existence of this file is only for some old projects that includes this file (cmsis_os2.h) but not add CMSIS/RTOS2/Include to their include pathes, this file just do a redirection for them, if they are willing to modify their makefile scripts, then this file could be removed.

So, this PR should be closed. We should push the old projects to do some changes now. :bowtie: @Nagesh

Caoruihong changed issue state from 待办的 to 修复中

Sign in to comment

Status
Assignees
Projects
Milestones
Pull Requests
Successfully merging a pull request will close this issue.
Branches
Planed to start   -   Planed to end
-
Top level
Priority
Duration (hours)
Confirm
参与者(2)
7989137 caoruihong 1601432415
C
1
https://git.oschina.net/openharmony/kernel_liteos_m.git
git@git.oschina.net:openharmony/kernel_liteos_m.git
openharmony
kernel_liteos_m
kernel_liteos_m

Search

182229 41614e54 1850385 182230 7885ed45 1850385