Have you reviewed every line of your changes by yourself?
Have you added enough test cases to cover the new feature or bug fix? Also, add comments to describe your test cases.
Do function names keep consistent with its behavior? Is it easy to infer the function's behavior by its name?
Is there any code that confuses the reviewer? Add comments on them! You'll be asked to do so anyway. Make sure there is no syntax or spelling error in your comments. Some online syntax checking tools like Grammarly may be helpful.
Is there any way to refactor the code to make it more readable? If the refactoring touches a lot of existing code, send another PR to do it.
Make sure the PR does only one thing and nothing else.
Make sure the diff size is no more than 500, split it into small PRs if it is too large.
此处可能存在不合适展示的内容,页面不予展示。您可通过相关编辑功能自查并修改。
如您确认内容无涉及 不当用语 / 纯广告导流 / 暴力 / 低俗色情 / 侵权 / 盗版 / 虚假 / 无价值内容或违法国家有关法律法规的内容,可点击提交进行申诉,我们将尽快为您处理。